Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground XYZ - new adapter #2606

Merged
merged 40 commits into from
Jun 7, 2018
Merged

Conversation

teranchristian
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
   {
      code: 'ad-unit-1',
      sizes: [[320, 50], [300, 250]],
      bids: [
        {
          bidder: 'playgroundxyz',
          params: {
            placementId: '12913056',           
         }
        }
      ]
    }

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

teranchristian and others added 30 commits October 18, 2017 15:09
change application type to application\json for playground adapter
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teranchristian LGTM. Just one thing
I think package-lock.json should not be in part of this PR.

@jaiminpanchal27
Copy link
Collaborator

Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

@teranchristian
Copy link
Contributor Author

Hi @jaiminpanchal27, thanks for reviewing our PR. I just removed the package-lock.json and added a minor change in the Overview (file .md). Also, we summited a PR to the docs repo and we are waiting for a fedback.

@jaiminpanchal27 jaiminpanchal27 merged commit af35a11 into prebid:master Jun 7, 2018
@jsnellbaker jsnellbaker mentioned this pull request Jun 8, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants